Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: mounted app views #1749

Merged
merged 4 commits into from
Feb 6, 2022
Merged

🐛 fix: mounted app views #1749

merged 4 commits into from
Feb 6, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Feb 4, 2022

Fixes #1276

ReneWerner87
ReneWerner87 requested changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding a list for the properties we want to take from the mounted apps, we should solve this differently

had some communication with the author of the pull request and we are working on a better variant

something like this
image
image
image
image

@efectn @ReneWerner87
Cleaner structure.
de0d409 
Co-authored-by: RW <rene@gofiber.io>
@ReneWerner87 ReneWerner87 merged commit c450072 into gofiber:master Feb 6, 2022
@ReneWerner87 ReneWerner87 mentioned this pull request Oct 20, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

Assignees
No one assigned
Labels
☢️ Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Mounted app views
2 participants
@efectn @ReneWerner87